feat: Implement rollback buffer #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasDP
reviewed
Feb 18, 2022
| @@ -7,7 +7,7 @@ pub const TESTNET_MAGIC: u64 = 1097911063; | |||
| pub const MAINNET_MAGIC: u64 = 764824073; | |||
|
|
|||
| /// A point within a chain | |||
| #[derive(Clone)] | |||
| #[derive(Clone, Eq, PartialEq)] | |||
| pub struct Point(pub u64, pub Vec<u8>); | |||
There was a problem hiding this comment.
what is the Vec<u8> here ? is it a block hash ?
There was a problem hiding this comment.
Yes, it is the hash. This struct was there before the introduction of pallas-crypto. We should turn it into a Hash<>.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a memory buffer to handle chain rollbacks.
This structure is intended to facilitate the process of managing rollbacks in a chain sync process. The goal is to keep
pointsin memory until they reach a certain depth (# of confirmations). If a rollback happens, the buffer will try to find the intersection, clear the orphaned points and keep the remaining still in memory. Further forward rolls will accumulate from the intersection.It works by keeping a
VecDequedata structure of points, where roll-forward operations accumulate at the end of the deque and retrieving confirmed points means to pop from the front of the deque.Notice that it works by keeping track of points, not blocks. It is meant to be used as a lightweight index where blocks can then be retrieved from a more suitable memory structure / persistent storage.